Skip to content

Commit

Permalink
Added libxml++2.6 to Bionic (ros#20673)
Browse files Browse the repository at this point in the history
* Added libxml++2.6 for bouncy

* Actually reformatted

* simplify libxml++2.6 rule

looking at this the dev package directly depends on the library package so there's no need to call out the specific library version. 

This holds for all supported versions of ubuntu: 
Trusty: https://packages.ubuntu.com/trusty/libxml++2.6-dev through Disco: https://packages.ubuntu.com/disco/libxml++2.6-dev

The debian rule is actually invalid due to the new library name at the moment. So I've proposed simplifying it too. 
https://packages.debian.org/buster/libxml++2.6-dev

This makes the rule more compact and maintainable going forward.

This rule is also noteably old and doesn't follow our conventions of including the `-dev` in the name, but I've chosen not to update it to avoid breaking any existing users.
  • Loading branch information
n30phyte authored and nuclearsandwich committed Mar 26, 2019
1 parent 1832a54 commit 08fc99a
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions rosdep/base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3587,17 +3587,10 @@ libxkbcommon-dev:
ubuntu: [libxkbcommon-dev]
libxml++-2.6:
arch: [libxml++]
debian: [libxml++2.6-2, libxml++2.6-dev]
debian: [libxml++2.6-dev]
fedora: [libxml++, libxml++-devel]
gentoo: ['dev-cpp/libxmlpp:2.6']
ubuntu:
precise: [libxml++2.6-2, libxml++2.6-dev]
saucy: [libxml++2.6-2, libxml++2.6-dev]
trusty: [libxml++2.6-2, libxml++2.6-dev]
utopic: [libxml++2.6-2, libxml++2.6-dev]
vivid: [libxml++2.6-2, libxml++2.6-dev]
wily: [libxml++2.6-2, libxml++2.6-dev]
xenial: [libxml++2.6-2v5, libxml++2.6-dev]
ubuntu: [libxml++2.6-dev]
libxml2:
arch: [libxml2]
debian: [libxml2-dev]
Expand Down

0 comments on commit 08fc99a

Please sign in to comment.