Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

chore: Upgrade to Nx and Angular 15, and other deps #49

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

borgoat
Copy link

@borgoat borgoat commented Jan 13, 2023

Hi! I was trying to use Angular 15 + the latest version of lexical itself, and was facing some issues. This MR includes the migration to Nx 15, Angular 15, Lexical, and the other dependencies.

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical-angular-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 13, 2023 at 2:16PM (UTC)

@borgoat borgoat changed the title Upgrade to Nx and Angular 15, and other deps chore: Upgrade to Nx and Angular 15, and other deps Jan 13, 2023
@troywweber7
Copy link

I've pulled this branch locally, done a pnpm i, had to fix multiple phantom dependencies (nx seems to have lots of these) using .pnpmfile.cjs, and I'm still struggling to get this to nx build. My hope was that until the main repo pulls this in, I could build the .tgz and rely on that for now, but it seems like there are still issues and I wonder if that could be holding up the merge request...

@riccardoperra
Copy link
Owner

I’ll do a test this weekend if I’m available
and plan a npm release with the newest features

@troywweber7
Copy link

@riccardoperra That would be awesome!

I've tried using Lexical vanilla, and I can see it is so abstracted out that it's got a steep learning curve. If I knew React better, I could probably translate it more easily. For the time being, since lexical-angular playground app seems to be broken, my only other option is to look at the components/directives for inspiration. But my confidence in my ability to do so dropped quickly when I couldn't even build the main branch. To top it off, I suspect there is something wrong with my pnpm setup that I need to straighten out.

Anyway, if this did get working for Angular 15, that would be very cool. Looks like a lot of thought has gone into how to Angular-ize Lexical.

@troywweber7
Copy link

troywweber7 commented Feb 22, 2023

@borgoat @riccardoperra Out of curiosity, what version of node are you using to develop this library? You have "@types/node": "16.11.7" so can I assume 16? I do wonder if that could be my issue with running the playground on main...

@troywweber7
Copy link

Sorry for the alarms. I have something wrong with my local install of pnpm. I was able to pnpm pack a tgz of this branch's library using docker and I'm testing using it now.

@troywweber7
Copy link

troywweber7 commented Feb 22, 2023

One immediate issue I notice right away is that packages/lexical-angular/package.json lists peer dependencies of angular common and core at version 13. These will need to be updated to match the top package json, I suspect. Same with tslib, probably.

In fact, if you remove them from the package.json altogether, then when you nx build they will be added to the package.json at the appropriate versions in the dist folder. Of course, if you need to pin it at certain versions, you would want to keep those entries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants