-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement malfeasance2 info method for GRPC API #6566
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #6566 +/- ##
========================================
Coverage 79.8% 79.8%
========================================
Files 355 356 +1
Lines 47110 47289 +179
========================================
+ Hits 37598 37743 +145
- Misses 7370 7400 +30
- Partials 2142 2146 +4 ☔ View full report in Codecov by Sentry. |
5360ae4
to
bf8abb4
Compare
1fc2d48
to
d32968c
Compare
bors merge |
## Motivation Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
Build failed: |
bors merge |
## Motivation Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
Build failed (retrying...): |
## Motivation Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
Pull request successfully merged into develop. Build succeeded: |
## Motivation Merge after #6566. This updates the way we handle metrics with malfeasance.
## Motivation Merge after #6566. This updates the way we handle metrics with malfeasance.
Motivation
Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
Description
This adds an implementation for the
Info
method ofmalfeasance2.Handler
. Since proofs are now split into their respective domains the handler will call another ATX-domain specific handler to extract the metadata and return it to the caller (GRPC handler).Test Plan
new unit tests were added where needed
TODO