Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement malfeasance2 info method for GRPC API #6566

Closed
wants to merge 11 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Dec 20, 2024

Motivation

Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.

Description

This adds an implementation for the Info method of malfeasance2.Handler. Since proofs are now split into their respective domains the handler will call another ATX-domain specific handler to extract the metadata and return it to the caller (GRPC handler).

Test Plan

new unit tests were added where needed

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 88.10573% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (2e6b90a) to head (d18381b).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
activation/handler_v1.go 40.0% 9 Missing and 3 partials ⚠️
sql/malfeasance/malfeasance.go 87.5% 4 Missing and 2 partials ⚠️
activation/malfeasance2.go 80.9% 3 Missing and 1 partial ⚠️
malfeasance2/handler.go 91.8% 2 Missing and 1 partial ⚠️
activation/wire/malfeasance_double_marry.go 89.4% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #6566    +/-   ##
========================================
  Coverage     79.8%   79.8%            
========================================
  Files          355     356     +1     
  Lines        47110   47289   +179     
========================================
+ Hits         37598   37743   +145     
- Misses        7370    7400    +30     
- Partials      2142    2146     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

activation/handler_v1.go Outdated Show resolved Hide resolved
@fasmat fasmat force-pushed the malfeasance-info-v2 branch from 1fc2d48 to d32968c Compare January 2, 2025 17:21
activation/handler_v1.go Outdated Show resolved Hide resolved
sql/malfeasance/malfeasance.go Outdated Show resolved Hide resolved
@fasmat
Copy link
Member Author

fasmat commented Jan 3, 2025

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 3, 2025
## Motivation

Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jan 3, 2025

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Jan 3, 2025

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 3, 2025
## Motivation

Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jan 3, 2025

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Jan 3, 2025
## Motivation

Followup for #6557. Now malfeasance2 proofs are actually fetched from the DB and metadata for them returned.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jan 3, 2025

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Implement malfeasance2 info method for GRPC API [Merged by Bors] - Implement malfeasance2 info method for GRPC API Jan 3, 2025
@spacemesh-bors spacemesh-bors bot closed this Jan 3, 2025
@spacemesh-bors spacemesh-bors bot deleted the malfeasance-info-v2 branch January 3, 2025 12:52
spacemesh-bors bot pushed a commit that referenced this pull request Jan 3, 2025
## Motivation

Merge after #6566. This updates the way we handle metrics with malfeasance.
spacemesh-bors bot pushed a commit that referenced this pull request Jan 3, 2025
## Motivation

Merge after #6566. This updates the way we handle metrics with malfeasance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants