Review feedback

activation/handler_v1.go

@@ -631,27 +631,27 @@
 	return types.BytesToHash(atx.NIPost.PostMetadata.Challenge), maps.Keys(filtered)
 }
 
-// Obtain the atxSignature of the given ATX.
+// Obtain the signature of the given ATX.
 func atxSignature(ctx context.Context, db sql.Executor, id types.ATXID) (types.EdSignature, error) {
 	var blob sql.Blob
 	v, err := atxs.LoadBlob(ctx, db, id.Bytes(), &blob)
 	if err != nil {
 		return types.EmptyEdSignature, err
 	}
 
 	if len(blob.Bytes) == 0 {
 		// An empty blob indicates a golden ATX (after a checkpoint-recovery).
 		return types.EmptyEdSignature, fmt.Errorf("can't get signature for a golden (checkpointed) ATX: %s", id)
 	}
 
 	switch v {
 	case types.AtxV1:
 		var atx wire.ActivationTxV1
 		if err := codec.Decode(blob.Bytes, &atx); err != nil {
 			return types.EmptyEdSignature, fmt.Errorf("decoding atx v1: %w", err)
 		}
 		return atx.Signature, nil
 	default: // only needed for V1 ATXs
 		return types.EmptyEdSignature, fmt.Errorf("unsupported ATX version: %v", v)
 	}
 }

hare3/hare.go

@@ -472,7 +472,7 @@ func (h *Hare) run(session *session) error {
 			if err := h.onOutput(session, current, out); err != nil {
 				return err
 			}
-			// we are logginng stats 1 network delay after new iteration start
+			// we are logging stats 1 network delay after new iteration start
 			// so that we can receive notify messages from previous iteration
 			if session.proto.Round == softlock && h.config.LogStats {
 				h.log.Debug("stats", zap.Uint32("lid", session.lid.Uint32()), zap.Inline(session.proto.Stats()))

hare4/hare.go

@@ -684,7 +684,7 @@ func (h *Hare) run(session *session) error {
 			if err := h.onOutput(session, current, out); err != nil {
 				return err
 			}
-			// we are logginng stats 1 network delay after new iteration start
+			// we are logging stats 1 network delay after new iteration start
 			// so that we can receive notify messages from previous iteration
 			if session.proto.Round == softlock && h.config.LogStats {
 				h.log.Info("stats", zap.Uint32("lid", session.lid.Uint32()), zap.Inline(session.proto.Stats()))

sql/malfeasance/malfeasance.go

@@ -96,8 +96,8 @@
 	return err
 }
 
-// Proof returns the malfeasance proof for the given node ID. Returns sql.ErrNotFound if no proof for the given node ID
-// exists. To return a proof for a marriage set use MarriageProof instead.
+// NodeIDProof returns the malfeasance proof and its domain for the given node ID. Returns sql.ErrNotFound if no proof
+// for the given node ID exists. To return a proof for a marriage set use MarriageProof instead.
 func NodeIDProof(db sql.Executor, nodeID types.NodeID) ([]byte, int, error) {
 	var (
 		proof  []byte
@@ -116,8 +116,8 @@
 		return false
 	})
 	if err != nil {
 		return nil, 0, fmt.Errorf("proof %v: %w", nodeID, err)
 	}
 	if rows == 0 {
 		return nil, 0, sql.ErrNotFound
 	}
@@ -144,8 +144,8 @@
 		return false
 	})
 	if err != nil {
 		return nil, 0, fmt.Errorf("marriage proof %v: %w", marriageID, err)
 	}
 	if rows == 0 {
 		return nil, 0, sql.ErrNotFound
 	}