Make sure channelInactive() and channelDeregistered() are triggered e…

…ven if outboundBuffer.recycle() fails
stephenyik · Jul 18, 2013 · fef838f · fef838f
1 parent 7215c01
commit fef838f
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/transport/src/main/java/io/netty/channel/AbstractChannel.java b/transport/src/main/java/io/netty/channel/AbstractChannel.java
@@ -523,22 +523,25 @@ public void run() {
                 }
 
                 // fail all queued messages
-                ChannelOutboundBuffer outboundBuffer = this.outboundBuffer;
-                outboundBuffer.failFlushed(CLOSED_CHANNEL_EXCEPTION);
-                outboundBuffer.failUnflushed(CLOSED_CHANNEL_EXCEPTION);
-                outboundBuffer.recycle();
-                this.outboundBuffer = null;
+                try {
+                    ChannelOutboundBuffer outboundBuffer = this.outboundBuffer;
+                    outboundBuffer.failFlushed(CLOSED_CHANNEL_EXCEPTION);
+                    outboundBuffer.failUnflushed(CLOSED_CHANNEL_EXCEPTION);
+                    outboundBuffer.recycle();
+                } finally {
+                    outboundBuffer = null;
+
+                    if (wasActive && !isActive()) {
+                        invokeLater(new Runnable() {
+                            @Override
+                            public void run() {
+                                pipeline.fireChannelInactive();
+                            }
+                        });
+                    }
 
-                if (wasActive && !isActive()) {
-                    invokeLater(new Runnable() {
-                        @Override
-                        public void run() {
-                            pipeline.fireChannelInactive();
-                        }
-                    });
+                    deregister(voidPromise());
                 }
-
-                deregister(voidPromise());
             } else {
                 // Closed already.
                 promise.setSuccess();