fix(travis): remove travis CI, replace with GH Actions #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLukowski
previously approved these changes
Sep 12, 2023
…5 changes" This reverts commit 88ea5d7.
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Avantol13
changed the title
jawadqur
previously approved these changes
Sep 15, 2023
tests/ci_commands_script.sh
Outdated
Comment on lines
6
to
11
| # since this whole thing is run as a bash {{this script}}, only the last pytest | ||
| # command controls the exit code. We actually want to exit early if something fails, | ||
| # so check that here and exit as necessary | ||
| RESULT=$? | ||
| if [ $RESULT -ne 0 ]; then | ||
| exit 1 |
There was a problem hiding this comment.
would it work to just set -e at the beginning of the script?
There was a problem hiding this comment.
Done and I tested it works by purposing failing a test in the middle run 👍
Comment on lines
+24
to
+25
| setup-script: 'tests/ci_setup.sh' | ||
| test-script: 'tests/ci_commands_script.sh' |
There was a problem hiding this comment.
since these 2 values are the same as the defaults, you could remove them from here, unless you want it to be more explicit where the files are used
There was a problem hiding this comment.
Yeah I figured since: a) I was gonna use this as an example PR for others to base theirs and b) it's clearer how it's working this way, it'd be better to be explicit
paulineribeyre
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes