-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(travis): remove travis CI, replace with GH Actions #400
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5485cfe
fix(travis): force a reasonable default distribution
Avantol13 188a644
fix(ci): install postgres
Avantol13 5bf2b4a
fix(ci): install postgres
Avantol13 fda307b
feat(gh): try to port unit test to GH Actions
Avantol13 b3610a2
fix(gh): ensure python commands run in venv
Avantol13 6deb74e
fix(ci): testing branch
Avantol13 9834946
chore(whitespace): remove
Avantol13 b5f79f5
chore(ci): force GH Actions rerun
Avantol13 da9d968
chore(ci): force GH Actions rerun
Avantol13 ed82a48
chore(ci): force GH Actions rerun
Avantol13 0bdf236
chore(ci): force GH Actions rerun
Avantol13 6ea1f1d
chore(ci): force GH Actions rerun
Avantol13 84dcc2b
chore(ci): force GH Actions rerun
Avantol13 372d37c
chore(ci): force GH Actions rerun
Avantol13 fc0af00
chore(ci): force GH Actions rerun
Avantol13 809ed5c
chore(ci): force GH Actions rerun
Avantol13 504e0f1
chore(ci): force GH Actions rerun
Avantol13 a08b493
fix(tests): update setup of postgres db to support postgres 15 changes
Avantol13 88ea5d7
fix(tests): update setup of postgres db to support postgres 15 changes
Avantol13 a5a8402
fix(tests): update setup of postgres db to support postgres 15 changes
Avantol13 7ec65fa
chore(ci): force GH Actions rerun
Avantol13 184fe28
chore(ci): force GH Actions rerun
Avantol13 c86c402
chore(ci): force GH Actions rerun
Avantol13 9a91f0a
chore(ci): force GH Actions rerun
Avantol13 719684b
Revert "fix(tests): update setup of postgres db to support postgres 1…
Avantol13 37054df
fix(ci): ensure exit code is error if any commands error
Avantol13 dd76ae5
fix(ci): ensure exit code is error if any commands error
Avantol13 2de6a09
chore(test): cleanup old "integration" tests
Avantol13 c41892b
chore(ci): add wool, update readme, update setup to defaults
Avantol13 ec81d18
chore(ci): remove travis
Avantol13 aedff22
Update ci.yaml
Avantol13 8010f36
chore(tests): simplify test run script and test failure
Avantol13 bb43511
Merge remote-tracking branch 'origin/fix/travis' into fix/travis
Avantol13 52c6b64
chore(tests): remove forced failure used for testing
Avantol13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
on: | ||
pull_request | ||
|
||
name: Wool | ||
|
||
jobs: | ||
runWool: | ||
name: Run black | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@master | ||
|
||
- uses: uc-cdis/wool@master | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/env bash | ||
|
||
# since this whole thing is run as a bash {{this script}}, only the last pytest | ||
# command controls the exit code. We actually want to exit early if something fails | ||
set -e | ||
|
||
# datadict and datadictwithobjid tests must run separately to allow | ||
# loading different datamodels | ||
poetry run pytest -vv --cov=sheepdog --cov-report xml tests/integration/datadict | ||
poetry run pytest -vv --cov=sheepdog --cov-report xml --cov-append tests/integration/datadictwithobjid | ||
poetry run pytest -vv --cov=sheepdog --cov-report xml --cov-append tests/unit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/usr/bin/env bash | ||
poetry run python bin/setup_test_database.py | ||
mkdir -p tests/integration/resources/keys | ||
cd tests/integration/resources/keys | ||
openssl genrsa -out test_private_key.pem 2048 | ||
openssl rsa -in test_private_key.pem -pubout -out test_public_key.pem | ||
cd - |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
TODO: Why are we integration testing alongside unit tests like this? We need to migrate | ||
these tests elsewhere b/c it's not really integration testing if we're | ||
configuring postgres exactly the way it expects in the CI running this. | ||
Since this CI setup is completely separate from how we run postgres in | ||
production, most of these tests are pointless. | ||
|
||
As of 13 SEP 23 I'm ripping out some of this to enable the migration | ||
to Github Actions from Travis CI. | ||
|
||
- Alex |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since these 2 values are the same as the defaults, you could remove them from here, unless you want it to be more explicit where the files are used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I figured since: a) I was gonna use this as an example PR for others to base theirs and b) it's clearer how it's working this way, it'd be better to be explicit