generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: 507 consentless analytics page views in aem eds, w/out launch container #534
Draft
pahupe
wants to merge
6
commits into
main
Choose a base branch
from
507-analytics-in-aem-eds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
pahupe
changed the title
507 analytics in aem eds
507 consentless analytics page views in aem eds, w/out launch container
Apr 26, 2024
pahupe
changed the title
507 consentless analytics page views in aem eds, w/out launch container
DRAFT: 507 consentless analytics page views in aem eds, w/out launch container
Apr 29, 2024
Converted to DRAFT as @urfuwo mentioned that data should also be tracked in CDI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Setup requested by Markus Riedinger:
Initial implementation validated with Sankalp Singh.
Fix #507
Test URLs:
Before: https://main--hlx-test--urfuwo.hlx.live/blog/2023/11/idc-marketscape-sap-a-leader-cloud-enabled-sourcing-applications
After: https://507-analytics-in-aem-eds--hlx-test--urfuwo.hlx.live/blog/2023/11/idc-marketscape-sap-a-leader-cloud-enabled-sourcing-applications
Validation: Open page (no ?tr parameter needed), open browser console and filter for requests containing "b/ss" in the URL. Per page we should see one request sending the (converted) Data Layer data to Analytics.
The format of the request follows the API specs: