Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: 507 consentless analytics page views in aem eds, w/out launch container #534

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pahupe
Copy link
Contributor

@pahupe pahupe commented Apr 26, 2024

Context: Setup requested by Markus Riedinger:

  • Remove Launch Container & Consent Manager
  • Add stripped-down logic to AEM EDS that takes the SAP Data Layer data, convert it to the Analytics Data Ingestion API format, send it to Analytics (News EDDL), report it in report dashboards

Initial implementation validated with Sankalp Singh.

Fix #507

Test URLs:
Before: https://main--hlx-test--urfuwo.hlx.live/blog/2023/11/idc-marketscape-sap-a-leader-cloud-enabled-sourcing-applications
After: https://507-analytics-in-aem-eds--hlx-test--urfuwo.hlx.live/blog/2023/11/idc-marketscape-sap-a-leader-cloud-enabled-sourcing-applications

Validation: Open page (no ?tr parameter needed), open browser console and filter for requests containing "b/ss" in the URL. Per page we should see one request sending the (converted) Data Layer data to Analytics.

The format of the request follows the API specs:

Copy link

aem-code-sync bot commented Apr 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to 507-analytics-in-aem-eds April 26, 2024 11:43 Inactive
Copy link

aem-code-sync bot commented Apr 26, 2024

@pahupe pahupe requested a review from saurabh-khare April 26, 2024 12:18
@aem-code-sync aem-code-sync bot temporarily deployed to 507-analytics-in-aem-eds April 26, 2024 12:18 Inactive
@pahupe pahupe requested review from karlpauls, mhaack and benpeter April 26, 2024 12:22
@pahupe pahupe changed the title 507 analytics in aem eds 507 consentless analytics page views in aem eds, w/out launch container Apr 26, 2024
@pahupe pahupe marked this pull request as draft April 29, 2024 08:05
@pahupe pahupe changed the title 507 consentless analytics page views in aem eds, w/out launch container DRAFT: 507 consentless analytics page views in aem eds, w/out launch container Apr 29, 2024
@pahupe
Copy link
Contributor Author

pahupe commented Apr 29, 2024

Converted to DRAFT as @urfuwo mentioned that data should also be tracked in CDI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Analytics] Send EDDL 1.0 (page view) data consentless from AEM EDS to Analytics
1 participant