Skip to content

Commit

Permalink
video: ssd1307fb: Do not hard code active-low reset sequence
Browse files Browse the repository at this point in the history
The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.

Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.

Signed-off-by: Michal Vokáč <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Rob Herring <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
  • Loading branch information
zandar authored and bzolnier committed Oct 8, 2018
1 parent 7d1b8d7 commit 9827f26
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/fbdev/ssd1307fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -667,10 +667,10 @@ static int ssd1307fb_probe(struct i2c_client *client,

if (par->reset) {
/* Reset the screen */
gpiod_set_value_cansleep(par->reset, 0);
udelay(4);
gpiod_set_value_cansleep(par->reset, 1);
udelay(4);
gpiod_set_value_cansleep(par->reset, 0);
udelay(4);
}

if (par->vbat_reg) {
Expand Down

0 comments on commit 9827f26

Please sign in to comment.