Killing hostile NPCs won't give "Killed innocent" morale debuff anymore

[Night-Pryanik]

Summary

Bugfixes "Killing hostile NPCs won't give "Killed innocent" morale debuff anymore"

Purpose of change

• Fixes "Killed Innocent" morale debuff from ambushing hostile bandit #30124 (hopefully).

At the moment, to NOT get the morale debuff for killing NPCs, said NPC has to be guaranteed_hostile. This condition is true if at least one of the following conditions is true:

1. said NPC is_enemy, which means that he must have NPC attitude of killing us (NPCATT_KILL) or fleeing from us (NPCATT_FLEE or NPCATT_FLEE_TEMP).
2. said NPC must have a faction, and this faction must dislike us a lot.

There are situations where hostile NPC isn't aware of us yet and thus is ignoring us and thus his NPC attitude is NPCATT_NULL. This means that first condition from the list above will be false.
As @mlangsdorf said in #30124 (comment), there might be some bugs or errors in faction assignment or evaluation, and this might be the reason why second condition from the list above also becomes false.
If both conditions are false, killing hostile NPC will give us a morale debuff.

Describe the solution

Added a check for hostile creature attitude, i.e. Creature::Attitude::HOSTILE. Hostile NPCs which haven't seen us yet (and thus not angry at us and not trying to kill us yet) have this attitude, and thus won't be considered as innocent, even if faction check fail for some reason.

In any case, if these changes won't fix the issue, this additional check for creature attitude won't hurt.

Describe alternatives you've considered

None.

Testing

I conducted A LOT of testing using several methods from #30124 and #71341, i.e. killing bandits spawned through Old Guard representative's mission, bandits in road block, bandits in bandits_garage and some others. I wasn't able to reproduce the original issue. If anyone has a save which can reliably reproduce the issue, please give it to me, I'll try to test it myself.

Additional context

None.

[RenechCDDA]

@Night-Pryanik I hate to mention this now but I only saw this in the feed after it was merged. There's a test case for this, player_morale_murdered_innocent.

https://github.com/CleverRaven/Cataclysm-DDA/blob/master/tests/morale_test.cpp#L175

If the test case didn't catch an existing error, it would be nice (not necessary, but nice!) if the test case could be made more comprehensive.

Again I'm not saying you have to do this, I just wanted to make you aware of the test.

[Night-Pryanik]

Ok, thanks, I'll check this out.