Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make barter / volume sorting account for stack size #78475

Merged

Conversation

kightlygeorge
Copy link
Contributor

Summary

Bugfixes "Make barter / volume sorting account for stack size"

Purpose of change

Fixes #77794

Describe the solution

Check the volume of the first item instead of the whole stack.

Describe alternatives you've considered

Testing

Before:
Screenshot_20241210_191310
After:
Screenshot_20241210_191604

Additional context

Maybe one day I'll be able to make simple changes without including obvious bugs.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 10, 2024
@kightlygeorge kightlygeorge changed the title Check first item volume instead of stack volume Make barter / volume sorting account for stack size Dec 10, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 11, 2024
@Night-Pryanik Night-Pryanik merged commit a9d20af into CleverRaven:master Dec 11, 2024
27 of 29 checks passed
@kightlygeorge kightlygeorge deleted the price-density-stack-fix branch December 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIM sorting by "barter value / volume" undervalues stacks
2 participants